Make samples/WasiPlayground actually publish and boot MTP on wasi-wasm by Evangelink · Pull Request #8558 · microsoft/testfx

Evangelink · 2026-05-25T12:16:04Z

Summary

Following PRs #7137 and #7146, Microsoft.Testing.Platform actually boots on the wasi-wasm runtime - but samples/WasiPlayground itself wouldn't even publish a dotnet.wasm bundle on the current preview SDK. This PR makes the sample build and run as far as MTP currently can on wasi, and documents the working procedure so others can repro the remaining blockers.

Changes

`samples/WasiPlayground/WasiPlayground.csproj`

Add three properties (with an inline comment explaining why) so dotnet publish produces a runnable bundle on 11.0.100-preview.5:

<UsingWasiRuntimeWorkload>true</UsingWasiRuntimeWorkload> - workaround for the preview-5 SDK manifest issue where $(UsingWasiRuntimeWorkload) never resolves to true for net10.0 projects, so the WASI Sdk targets are never imported and no dotnet.wasm bundle is produced.
<WasmSingleFileBundle>false</WasmSingleFileBundle> - single-file bundling requires the wasi-sdk (clang) toolchain to relink the native runtime, which is a heavy prerequisite to drop on a sample. Keeping the managed assemblies on disk avoids it.
<InvariantGlobalization>true</InvariantGlobalization> - the trimmed build otherwise crashes on startup trying to load icudt.dat from cwd.

Also removed the duplicate <OutputType>Exe</OutputType> line.

`samples/WasiPlayground/README.md`

Rewrite the README to reflect the current working procedure:

Install wasi-experimental-net10 + wasm-tools-net10 workloads.
dotnet publish samples\WasiPlayground\WasiPlayground.csproj -c Debug -f net10.0.
Copy icudt.dat from the runtime pack into the AppBundle (still required even with InvariantGlobalization=true because the pre-built dotnet.wasm does not embed it).
Run with wasmtime run -S http --dir . -- dotnet.wasm WasiPlayground (the -S http flag is required because the runtime imports wasi:http).

Document the current end-state: MTP boots and prints [wasi-wasm - net10.0], then fails inside the compiler-generated Main wrapper that synchronously waits on Task (tracked in #5366) - this PR doesn't try to fix that upstream issue, it just makes the sample reproduce it cleanly.

Also call out the non-obvious build switches in a small table at the bottom of the README.

Validation

Verified locally on Windows with the repo-local Q:\src\testfx\.dotnet\dotnet.exe:

.\.dotnet\dotnet.exe publish samples\WasiPlayground\WasiPlayground.csproj -c Debug -f net10.0
copy .dotnet\packs\Microsoft.NETCore.App.Runtime.Mono.wasi-wasm\10.0.7\runtimes\wasi-wasm\native\icudt.dat artifacts\bin\WasiPlayground\Debug\net10.0\wasi-wasm\AppBundle\
cd artifacts\bin\WasiPlayground\Debug\net10.0\wasi-wasm\AppBundle
wasmtime run -S http --dir . -- dotnet.wasm WasiPlayground

Output:

Microsoft.Testing.Platform v...  [wasi-wasm - net10.0]
...
Unhandled Exception:
System.PlatformNotSupportedException: Arg_PlatformNotSupported
   at System.Threading.Tasks.Task.InternalWaitCore(...)
   at System.Threading.Tasks.Task.InternalWait(...)
   at Program.<Main>(String[] args)

That final exception is the known async-Main blocker - tracked in #5366 - and intentionally not addressed here.

Related issues / follow-ups

Refs Enable test execution in browser-wasm #2196 - Enable test execution in browser-wasm
Refs Allow running on wasm platform #5366 - Allow running on wasm platform (the Task.InternalWaitCore blocker shown above)
Follow-up Add [UnsupportedOSPlatform("wasi")] to HangDump / Console / Process surface #8557 - Add [UnsupportedOSPlatform("wasi")] to HangDump / Console / Process surface (filed during this investigation)

Copilot

Pull request overview

Updates the samples/WasiPlayground sample so it can be published into a runnable wasi-wasm bundle with the repo-pinned .NET SDK, and refreshes the README to document the current end-to-end repro path for MTP on WASI.

Changes:

Adjust WasiPlayground.csproj WASI publish settings (disable single-file bundle, enable invariant globalization, force WASI workload import workaround).
Rewrite samples/WasiPlayground/README.md with updated prerequisites, publish/run steps, and current known failure mode.

Show a summary per file

File	Description
samples/WasiPlayground/WasiPlayground.csproj	Adds WASI publish/workaround properties so `dotnet publish` produces a runnable `dotnet.wasm` bundle on the pinned preview SDK.
samples/WasiPlayground/README.md	Documents the updated workflow to publish, stage ICU data, and run under wasmtime; records current platform limitations.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

Evangelink

#	Dimension	Verdict
17	Documentation Accuracy	🟡 2 MODERATE

✅ 20/21 dimensions clean.

Documentation Accuracy — InvariantGlobalization explanation needs clarification to prevent user confusion
Documentation Accuracy — Missing issue reference (#5366) for the tracked blocker

This PR successfully makes the WasiPlayground sample buildable and documents the current WASI support status. The changes are well-scoped and the MSBuild properties are correctly configured. The two documentation clarity issues above are recommended improvements to prevent user confusion, but they don't block the PR's core objective.

Dimensions reviewed:

✅ Code Structure & Simplification — Duplicate OutputType correctly removed
✅ MSBuild Authoring — Properties correctly formatted with helpful comments
✅ Naming & Conventions — Follows conventions
✅ Scope & PR Discipline — Single concern, appropriate references
🟡 Documentation Accuracy — Two clarity improvements needed (see inline comments)

Dimensions N/A (no applicable code): Algorithmic Correctness, Threading & Concurrency, Security, Public API, Performance, Cross-TFM, Resource Management, Defensive Coding, Localization, Test Isolation, Assertion Quality, Flakiness, Test Coverage, Data-Driven Tests, Analyzer Quality, IPC Wire, Build Infrastructure

Generated by Expert Code Review (on open) for issue #8558 · ● 1.1M

After PRs #7137 and #7146, Microsoft.Testing.Platform boots on the wasi-wasm runtime, but the sample wouldn't even produce a `dotnet.wasm` bundle out of the box on the current preview SDK (`11.0.100-preview.5`): * `WorkloadManifest.Wasi.targets` only resolves `$(UsingWasiRuntimeWorkload)` to `true` when `$(TargetsCurrent)` (net11.0) is true, never when `$(TargetsNet10)` is true, so the WASI Sdk targets are never imported. * The pre-built `dotnet.wasm` tries to read `icudt.dat` from `cwd` even when `InvariantGlobalization` is on, so trimmed builds crash on startup. * `WasmSingleFileBundle=true` requires `wasi-sdk` (clang) to relink the native runtime, which is a heavy prerequisite for a sample. Set the matching properties explicitly on the project so a plain `dotnet publish` produces a runnable bundle, and document the new working build / run procedure (and the remaining `Task.Wait` blocker tracked in #5366) in the README. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

samples/WasiPlayground/WasiPlayground.csproj sets <UsingWasiRuntimeWorkload> which makes Microsoft.NET.Sdk.ImportWorkloads.targets emit NETSDK1147 unless the wasi-experimental-net10 workload is installed in the repo-local .dotnet/ SDK that Arcade bootstraps. Plug into Arcade's restore-toolset.ps1 extension point so the workload is installed after InitializeDotNetCli, both in CI and for local 'build.cmd' runs. The script fast-paths when the workload is already installed by parsing 'dotnet workload list' output (no network). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Program.cs: - Drop AddHangDumpProvider() registration: PR #8564 marked it [UnsupportedOSPlatform(\"wasi\")], so CA1416 now flags the call site in a wasi-wasm sample. Hang dumps rely on System.Diagnostics.Process which is not available on wasi; leave a comment in place of the call to explain the intentional omission. README.md: - Replace the hard-coded runtime-pack version 10.0.7 (already out of sync with global.json 10.0.8) with a 'dir /b' lookup followed by a <runtime-version> placeholder. - Clarify InvariantGlobalization=true: it prevents the trimmer from crashing during publish but the pre-built dotnet.wasm still loads ICU at runtime, so step 2 is still required. - Link the tracked async-Main blocker to #5366 instead of saying 'Tracked separately'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 4/4 changed files
Comments generated: 3

- Program.cs: correct issue link from #8564 to #8557. - README.md: drop trailing blank line (markdownlint MD012). - WasiPlayground.csproj: only set IsTestingPlatformApplication when not running under 'dotnet test'. The Windows Debug Test step on TestFx.slnx now invokes WasmAppHost (because the proper wasi workload installation produces a real wasm bundle) and fails because Windows CI agents have no wasmtime on PATH. - restore-toolset.ps1: drop --skip-sign-check (don't weaken supply-chain integrity) and note why wasm-tools-net10 is intentionally omitted (only needed for 'dotnet publish'). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 4/4 changed files
Comments generated: 2

- Add eng/restore-toolset.sh so Unix builds also install the WASI workload (eng/common/build.sh dot-sources it from InitializeCustomToolset). - README: use repo-local .\.dotnet\dotnet.exe consistently so the .dotnet\packs lookup in step 2 resolves; document the machine-SDK swap. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 25, 2026 12:16

Copilot started reviewing on behalf of Evangelink May 25, 2026 12:16 View session

Copilot AI reviewed May 25, 2026

View reviewed changes

Comment thread samples/WasiPlayground/README.md Outdated

Evangelink commented May 25, 2026

View reviewed changes

Comment thread samples/WasiPlayground/README.md

Comment thread samples/WasiPlayground/README.md Outdated

Evangelink and others added 3 commits May 25, 2026 18:09

Copilot AI review requested due to automatic review settings May 25, 2026 16:11

Evangelink force-pushed the dev/amauryleve/wasi-playground-fixups branch from 8283951 to 72e6094 Compare May 25, 2026 16:11

Copilot started reviewing on behalf of Evangelink May 25, 2026 16:12 View session

Copilot AI reviewed May 25, 2026

View reviewed changes

Comment thread samples/WasiPlayground/Program.cs Outdated

Comment thread eng/restore-toolset.ps1

Comment thread eng/restore-toolset.ps1

Evangelink and others added 2 commits May 26, 2026 16:42

Merge branch 'main' into dev/amauryleve/wasi-playground-fixups

f7f8c46

Copilot AI review requested due to automatic review settings May 26, 2026 14:53

Copilot started reviewing on behalf of Evangelink May 26, 2026 14:54 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

Comment thread eng/restore-toolset.ps1

Comment thread samples/WasiPlayground/README.md Outdated

Evangelink merged commit 5759de9 into main May 27, 2026
45 of 49 checks passed

Evangelink deleted the dev/amauryleve/wasi-playground-fixups branch May 27, 2026 09:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make samples/WasiPlayground actually publish and boot MTP on wasi-wasm#8558

Make samples/WasiPlayground actually publish and boot MTP on wasi-wasm#8558
Evangelink merged 6 commits into
mainfrom
dev/amauryleve/wasi-playground-fixups

Evangelink commented May 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Evangelink left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Evangelink commented May 25, 2026

Summary

Changes

samples/WasiPlayground/WasiPlayground.csproj

samples/WasiPlayground/README.md

Validation

Related issues / follow-ups

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Evangelink left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`samples/WasiPlayground/WasiPlayground.csproj`

`samples/WasiPlayground/README.md`